Repository navigation
fix: finish the template upgrade and make the owner-file gates pass - #22
Merged
Merged
Conversation
rsr-template-repo#343 (2f54c7b) fixed or justified the 10 SonarCloud findings every child inherits; this branch was minted from 840ac25, so Sonar rated it D on new code. Apply the two template commits since the pin, 6c845c9 (SessionStart hook for commit signing) and 2f54c7b (the Sonar fixes), unchanged, and repoint (provenance) and :parent-pin to 2f54c7b (tree 1d693c6). mise.toml is declared diverged: it keeps the repo's julia line (a2e0a8d). check-mint-drift.sh against 2f54c7b: identical modulo declared paths. Canon lockstep, root shape, lock sync, validate-claude-md, validate-repo-map and template_instantiation_test pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZohGxQnA5cbBZyi8Wp
- JCS: reserialise examples/session_ir/manifest.json and
src/stackcert/lake-manifest.json (check-ijson-jcs --enforce).
- docs/EXPLAINME.adoc: one level-0 title only. The project title
replaces the template title, and "RSR template claims" becomes a
level-1 section (asciidoctor: level 0 needs doctype book).
- docs/recon/ULTRA-PLAN-2026-10-04.adoc: remove a stray |=== that
closed the table one row early ("table missing leading separator").
- PROOF-STATUS.adoc: name the README placeholder without the literal
token, so check-no-placeholders passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZohGxQnA5cbBZyi8Wp
Contributor
|
Caution Review failedThe pull request is closed. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
🟠 indeterminate · commit Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change. Unique graded findings across gating and advisory rows: 42 (42 reporter observations; 20 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Hypatia scan: error — the scanner produced no SARIF projection
panic-attack assail: 17 finding(s)
pons asinorum: 9 finding(s)
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
rhodibot (RSR compliance): 13 finding(s)
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
glambot (presentation quality): 100 finding(s)
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
finishingbot (release readiness): 189 finding(s)
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #21. That PR merged before its last commit arrived. This PR carries that commit, plus the gate fixes in the owner's files that the owner approved (selector, 2026-11-12: "Fix in a follow-up PR").
Changes
chore: move the template pin to rsr-template-repo 2f54c7b(the commit that missed chore: upgrade to the current RSR template (840ac25), then instantiate #21)::parent-pinand:template-committo 2f54c7b, and:template-treeto match.mise.tomlas diverged (it carriesjulia = "1.10").fix: make the owner-file gates pass:examples/session_ir/manifest.jsonandsrc/stackcert/lake-manifest.json.docs/EXPLAINME.adoc: one level-0 title. The project title replaces the template title, and "RSR template claims" becomes a level-1 section.docs/recon/ULTRA-PLAN-2026-10-04.adoc: remove a stray|===that closed a table one row early.PROOF-STATUS.adoc: name the README placeholder without the literal{{...}}token.No content in these files changes meaning. The edits are layout and serialisation only.
RSR Quality Checklist
Required
As Applicable
Testing
All run locally on this branch:
scripts/check-ijson-jcs.sh --enforce: 18 of 18 canonical.scripts/check-adoc-renders.sh(asciidoctor 2.0.26): all 177 tracked .adoc files render clean.scripts/check-no-placeholders.sh: PASS.scripts/check-mint-drift.shagainst rsr-template-repo 2f54c7b: PASS, identical to a replay of the mint modulo declared variant paths.The
mise.tomlJulia line still needs hyperpolymath/rsr-template-repo#345 (Julia detection below the root) beforecheck-mise-language.shpasses here.Screenshots
Not applicable.
Generated by Claude Code